ReadRange problem in rr_address_list_encode #1129
maimomohali
started this conversation in
General
Replies: 1 comment
-
|
I created issue [#1144] from this discussion. Thank you for reporting the problem. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
File: src/bacnet/basic/binding/address.c
While debugging the ReadRange service, I found that the function rr_address_list_encode() is not working correctly.
In my test (see attached test1.jpg),
the device has 1 binding entry, and I requested a ReadRange.
However, although the Item Count is correctly reported as 1, there is no ItemData in the response packet.
After investigation, I found that the following section seems problematic:
This logic causes the function to return prematurely, even when a valid entry exists at the end of the table.
So I modified it as follows:
After this change, the response became normal, and the ItemData was properly encoded.
Even if not exactly in this way,
I believe this section requires a review or adjustment to handle end-of-table conditions properly.
Beta Was this translation helpful? Give feedback.
All reactions