refactor(ts): migrate babel-eslint-plugin-* to TS#17950
Conversation
JLHwung
added
the
PR: Internal 🏠
| } | ||
|
|
||
| if (parent.type === "ExportNamedDeclaration") { | ||
| return node.id.name; |
There was a problem hiding this comment.
This file is renamed to is-default-export such that we don't have to deal with the typing issue here from destructuring at all.
JLHwung
force-pushed
the
migrate-babel-eslint-ts
branch
from
015a26f to
b0e7cbb
Compare
| }, | ||
| "homepage": "https://babel.dev/", | ||
| "peerDependencies": { | ||
| "eslint": "^9.0.0 || ^10.0.0" |
There was a problem hiding this comment.
We add the eslint peer deps constraint to align with other eslint plugins.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61383 |
| }, | ||
| "homepage": "https://github.com/babel/babel/tree/master/eslint/babel-eslint-plugin-development-internal", | ||
| "peerDependencies": { | ||
| "@babel/eslint-parser": "workspace:^", |
There was a problem hiding this comment.
This eslint plugin does not work on any early stage features and therefore we remove the @babel/eslint-parser from the peer deps. Of course it should still work with @babel/eslint-parser.
|
commit: |
| "new-cap": "off", | ||
| "no-undef": "off", | ||
| "object-curly-spacing": "off", | ||
| "no-unused-expressions": "off", |
There was a problem hiding this comment.
This is a bug fix. The object-curly-spacing rule has already been removed as ESLint has deprecated that rule.
3 participants
esling-plugin-development, see added new tests for the specificsIn this PR we migrate
babel-eslint-plugin-*and fixed all typing errors. The only introduced@ts-expect-erroris for an upstream typing issue.We also fixed small bugs detected by tsc and added new tests.