Skip to content

Allow $schema property in json config files - #14067

Merged
JLHwung merged 2 commits into
babel:mainfrom
The-x-Theorist:schema-property-json-config
Dec 29, 2021
Merged

JLHwung merged 2 commits into
babel:mainfrom
The-x-Theorist:schema-property-json-config

Conversation

@The-x-Theorist

@The-x-Theorist The-x-Theorist commented Dec 20, 2021 •

Copy link
Copy Markdown
Contributor
Q 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 A
Fixed Issues? Fixes #14038
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

$schema property will be deleted from json config files, while file is being read.

@babel-bot

babel-bot commented Dec 20, 2021 •

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50436/

@nicolo-ribaudo nicolo-ribaudo changed the title Fix: Error on property in json config files Allow $schema property in json config files Dec 20, 2021
@nicolo-ribaudo nicolo-ribaudo added the PR: Polish 馃拝 A type of pull request used for our changelog categories label Dec 20, 2021
Comment thread packages/babel-core/src/config/files/configuration.ts Outdated

@JLHwung JLHwung left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung
JLHwung merged commit 2c68d03 into babel:main Dec 29, 2021
@The-x-Theorist
The-x-Theorist deleted the schema-property-json-config branch December 29, 2021 05:45
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 5, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 馃拝 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Babel is throwing an error at the $schema property in json config files

5 participants