Skip to content

Only resolve package.json when relative configs are enabled - #13063

Merged
nicolo-ribaudo merged 1 commit into
babel:mainfrom
nicolo-ribaudo:find-package-data-perf
Mar 28, 2021
Merged

nicolo-ribaudo merged 1 commit into
babel:mainfrom
nicolo-ribaudo:find-package-data-perf

Conversation

@nicolo-ribaudo

Copy link
Copy Markdown
Member
Q                       A
Fixed Issues? Fixes #13006
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

When reviewing this PR, disable whitespace changes in the diff since most of the changed lines have only been indented by one level more.

@nicolo-ribaudo nicolo-ribaudo added pkg: core PR: Performance 🏃‍♀️ A type of pull request used for our changelog categories labels Mar 27, 2021
@babel-bot

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44825/

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f73a65b:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo changed the title Only resolve .babelrc files when they are not disabled Only resolve package.json when .babelrc files are not disabled Mar 27, 2021

@hzoo hzoo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double negative was confusing haha, but I guess it's default to enabled?

@nicolo-ribaudo

Copy link
Copy Markdown
Member Author

Yeah right, enabled is the default!

@nicolo-ribaudo
nicolo-ribaudo merged commit 06eb3b7 into babel:main Mar 28, 2021
@nicolo-ribaudo
nicolo-ribaudo deleted the find-package-data-perf branch March 28, 2021 10:04
@nicolo-ribaudo nicolo-ribaudo changed the title Only resolve package.json when .babelrc files are not disabled Only resolve package.json when relative configs are enabled Mar 28, 2021
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 28, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: core PR: Performance 🏃‍♀️ A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

loadFullConfig wastes time on findConfigUpwards again when I've already done loadOptions with rootMode: 'upward-optional'

4 participants