fix(core): properly propagate async errors in interceptor chain #7161
+79
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests to verify onRequestError handling for both synchronous and asynchronous request interceptors. Currently, the behavior is correct for synchronous interceptors but failing for asynchronous ones. Refs: axios#7044
Ensures that onRequestError is called when an asynchronous request interceptor throws. Previously, the behavior matched for synchronous interceptors but failed for asynchronous ones. Closes: axios#7044
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your pull request here.
Fixes: #7044
It adds test cases and a fix to ensure
onRequestErroris triggered consistently when a request interceptor throws an error — both in synchronous and asynchronous modes.Previously, Axios correctly handled synchronous interceptor errors but did not call
onRequestErrorfor asynchronous interceptors.✅ Changes
🧪 Behavior Before
onRequestErrorcalled ✅onRequestErrornot called ❌🧠 Behavior After
onRequestErrorcalled ✅onRequestErrorcalled ✅