fix(core): fix IE11 support by removing the isEmptyObject util #7128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was used in mergeConfig to merge the custom headers objects; BREAKING CHANGE: merging custom objects is now supported only for header configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The utility doesn't check whether the passed object is actually an object, which causes an error in IE11. It was used inside mergeConfig to merge custom objects in a rather strange way, so mergeConfig has been reworked, and the utility has been completely removed as it is no longer needed. For compatibility reasons, the functionality has been re-implemented, but only for the headers config. This functionality is not available at all in the 1.x branch and its usefulness is questionable.
BREAKING CHANGE: merging custom objects is now supported only for the header config.
Fixes #7111
Ref #4871