add main name to import function#6
Open
bravecorvus wants to merge 1 commit intoaws-samples:masterfrom
Open
Conversation
|
Why is this not merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
I just made the changes to
main_test.gowhich follow the docs. without the rename ofmainfor the "package"github.com/aws-samples/lambda-go-samples,main_test.gowill not be able to find the package namespacemain.However, this still does not fix the problem that since
main.gois not actually a package (it is a program driver). I am not entirely sure how to test a main program in this way in idiomatic go, but I hope this gets a little closer to the fix.The exact message in my code is:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.