fix(parser): fallback to validate_python when using type[Model] and nested models#5313
Merged
Merged
Conversation
validation_python to validate models with type modelvalidate_python for type[Model] and nested models
validate_python for type[Model] and nested modelsvalidate_python when using type[Model] and nested models
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5313 +/- ##
========================================
Coverage 96.20% 96.20%
========================================
Files 229 229
Lines 10753 10761 +8
Branches 2002 2001 -1
========================================
+ Hits 10345 10353 +8
Misses 322 322
Partials 86 86 ☔ View full report in Codecov by Sentry. |
dreamorosi
approved these changes
Oct 7, 2024
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: #5303
Summary
Changes
In Pydantic v2, when validating a model that has a field with a type of another model can break the validation. This limitation/bug in Pydantic is causing problems for customers trying to validate JSON against complex model structures
To work around this issue, we are modifying the validation code to use a try/except block. If a
NotImplementedErroris raised during JSON validation, we can fall back to usingvalidate_pythoninstead.I added additional tests to make sure we are covering this part of code and also a e2e test.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.