fix: remove unnecessary typing-extensions for py3.8#281
Merged
heitorlessa merged 3 commits intoaws-powertools:developfrom Feb 4, 2021
Merged
fix: remove unnecessary typing-extensions for py3.8#281heitorlessa merged 3 commits intoaws-powertools:developfrom
heitorlessa merged 3 commits intoaws-powertools:developfrom
Conversation
nadobando
force-pushed
the
fix/remove-typing-ext-for-py38
branch
from
c1e7324 to
fc78bea
Compare
Codecov Report
@@ Coverage Diff @@
## develop #281 +/- ##
===========================================
- Coverage 99.75% 99.68% -0.07%
===========================================
Files 79 79
Lines 2839 2861 +22
Branches 118 120 +2
===========================================
+ Hits 2832 2852 +20
- Misses 5 7 +2
Partials 2 2
Continue to review full report at Codecov.
|
nadobando
force-pushed
the
fix/remove-typing-ext-for-py38
branch
from
fc78bea to
f584ed4
Compare
to-mc
suggested changes
Feb 3, 2021
Contributor
to-mc
left a comment
to-mc
left a comment
There was a problem hiding this comment.
Nice change, great to keep the package size down where we can! Added a small suggestion to change - otherwise LGTM!
nadobando
force-pushed
the
fix/remove-typing-ext-for-py38
branch
from
f584ed4 to
11627ff
Compare
to-mc
approved these changes
Feb 3, 2021
Contributor
|
Thanks a lot for this contribution @nadobando !!! And thanks @cakepietoast for the review. Merging this and publishing a new release |
* develop: chore: bump to 1.10.2 (aws-powertools#282) fix: batch processing exceptions (aws-powertools#276)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #280
Description of changes:
Added if block to know if typing_extensions should be imported based on the python version.
if python >= 3.8 typing extensions will not be imported and the native implementation will be used
else will try to import typing_extensions and catch the ImportError
Updated modules which imported this dependency.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.