fix: parser S3Model not compatible with ObjectRemoved events - #1639
fix: parser S3Model not compatible with ObjectRemoved events#1639ran-isenberg wants to merge 1 commit into
Conversation
|
Thanks @ran-isenberg! I'm back with my laptop, so I was about to test it now. Would it be fine if I cherrypick your commit into a single PR? |
|
Yeah sure np! I had to make some fixes to the validator. |
|
I see you added an |
no, it's not needed, i think you can remove the extra test case too. |
|
I think it should be done now then. Can you double-check #1638 to see if I missed anything from your changes? |
|
@leandrodamascena let's merge @ran-isenberg into @barreeeiroo PR, and make sure @ran-isenberg is a co-author in that PR |
|
nvm, it is already in (need coffee). I'll merge and add Ran as a co-author |
|
@heitorlessa it's already merged there |
issue #1637