fix(kafka): Handle message indices in proto data also for Glue Schema Registry#1906
Closed
karthikpswamy wants to merge 3 commits intoaws-powertools:mainfrom
Closed
fix(kafka): Handle message indices in proto data also for Glue Schema Registry#1906karthikpswamy wants to merge 3 commits intoaws-powertools:mainfrom
karthikpswamy wants to merge 3 commits intoaws-powertools:mainfrom
Conversation
...main/java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializer.java
Outdated
Show resolved
Hide resolved
...main/java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializer.java
Outdated
Show resolved
Hide resolved
...main/java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializer.java
Outdated
Show resolved
Hide resolved
...main/java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializer.java
Outdated
Show resolved
Hide resolved
|
phipag
requested changes
Jun 20, 2025
.../java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializerTest.java
Show resolved
Hide resolved
.../java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializerTest.java
Show resolved
Hide resolved
...main/java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializer.java
Show resolved
Hide resolved
phipag
requested changes
Jun 20, 2025
...main/java/software/amazon/lambda/powertools/kafka/serializers/AbstractKafkaDeserializer.java
Show resolved
Hide resolved
...main/java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializer.java
Show resolved
Hide resolved
...main/java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializer.java
Show resolved
Hide resolved
phipag
reviewed
Jun 20, 2025
phipag
reviewed
Jun 20, 2025
...main/java/software/amazon/lambda/powertools/kafka/serializers/AbstractKafkaDeserializer.java
Show resolved
Hide resolved
4 tasks
Contributor
|
Hey @karthikpswamy. Thanks again for contributing this logic. To unblock work during my timezone I created a copy of your PR here: #1907. Please review it. I did some minor changes but the key change is that I updated the GLUE Schema ID size to 36 because this is length of the uuids. Can you let me know if this is correct? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue #, if available:
Description of changes:
Schema Registry Type Detection and Deserialization Logic:
No Schema Registry Integration:
Identified by 16-byte schema ID in key/value metadata
Default case when neither of above conditions are met
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.