-
Notifications
You must be signed in to change notification settings - Fork 2.2k
release(required): Amplify JS release #14610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
soberm
wants to merge
19
commits into
release
Choose a base branch
from
main
base: release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+921
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…learing Fixes the critical issue where users are randomly logged out due to TokenOrchestrator clearing tokens for ANY non-network error, including transient AWS service issues. Resolves #14534 The `handleErrors()` method was clearing tokens for all errors except NetworkError, causing users to be logged out during: - AWS service errors (500s) - Rate limiting (TooManyRequestsException) - Temporary service unavailability - Other transient errors that should be retried Modified token clearing logic to only clear tokens for definitive authentication failures that require re-authentication. Transient errors now preserve tokens, allowing for retry without forcing users to log in again. - Removed overly broad token clearing condition - Added `isAuthenticationError()` helper to identify auth failures - Only clears tokens for errors that definitively indicate invalid/expired tokens - Preserves tokens for all transient/retryable errors - `NotAuthorizedException` - Refresh token expired/invalid - `TokenRevokedException` - Token explicitly revoked - `UserNotFoundException` - User no longer exists - `PasswordResetRequiredException` - Password reset required - `UserNotConfirmedException` - Account not confirmed - `InternalErrorException` - AWS service errors - `TooManyRequestsException` - Rate limiting - `ThrottlingException` - Request throttling - `ServiceUnavailable` - Temporary service issues - `NetworkError` - Network connectivity issues - Any other transient or unknown errors - Added comprehensive test coverage for all error scenarios - Tests verify correct token clearing behavior for each error type - All existing tests pass This fix ensures users remain logged in during temporary AWS service issues while still properly handling genuine authentication failures.
…t calendar issue. (#14579)
…gh OAuth using signInWithRedirect function (#14573)
sarayev
approved these changes
Nov 5, 2025
Simone319
approved these changes
Nov 5, 2025
ahmedhamouda78
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.