test: use accurate errors in testing (#7273)

trivikr · web-flow · commit 97e916eeaaee · 2025-08-21T07:15:54.000-07:00
diff --git a/packages/credential-provider-ini/src/resolveAssumeRoleCredentials.spec.ts b/packages/credential-provider-ini/src/resolveAssumeRoleCredentials.spec.ts
@@ -142,7 +142,7 @@ describe(resolveAssumeRoleCredentials.name, () => {
       `Detected a cycle attempting to resolve credentials for profile` +
         ` ${mockProfileName}. Profiles visited: ` +
         Object.keys({ mockProfileName: true }).join(", "),
-      false
+      { tryNextLink: true }
     );
 
     try {
diff --git a/packages/credential-provider-sso/src/fromSSO.spec.ts b/packages/credential-provider-sso/src/fromSSO.spec.ts
@@ -130,7 +130,8 @@ describe(fromSSO.name, () => {
     it.each(["ssoStartUrl", "ssoAccountId", "ssoRegion", "ssoRoleName"])("missing '%s'", async (key) => {
       const expectedError = new CredentialsProviderError(
         'Incomplete configuration. The fromSSO() argument hash must include "ssoStartUrl",' +
-          ' "ssoAccountId", "ssoRegion", "ssoRoleName"'
+          ' "ssoAccountId", "ssoRegion", "ssoRoleName"',
+        { tryNextLink: false }
       );
       try {
         await fromSSO({ ...mockSsoProfile, [key]: undefined })();
diff --git a/packages/middleware-endpoint-discovery/src/updateDiscoveredEndpointInCache.spec.ts b/packages/middleware-endpoint-discovery/src/updateDiscoveredEndpointInCache.spec.ts
@@ -117,7 +117,7 @@ describe(updateDiscoveredEndpointInCache.name, () => {
                 `The operation to discover endpoint failed.` +
                   ` Please retry, or provide a custom endpoint and disable endpoint discovery to proceed.`
               ),
-              { reason: error }
+              { reason: new Error("rejected") }
             )
           );
         }
diff --git a/packages/middleware-sdk-s3/src/region-redirect-middleware.spec.ts b/packages/middleware-sdk-s3/src/region-redirect-middleware.spec.ts
@@ -60,7 +60,7 @@ describe(regionRedirectMiddleware.name, () => {
       await handler({ input: null });
     }).rejects.toThrowError(
       Object.assign(new Error(), {
-        Code: "PermanentRedirect",
+        name: "PermanentRedirect",
         $metadata: { httpStatusCode: 301 },
         $response: { headers: { "x-amz-bucket-region": redirectRegion } },
       })
diff --git a/packages/s3-request-presigner/src/getSignedUrl.spec.ts b/packages/s3-request-presigner/src/getSignedUrl.spec.ts
@@ -196,9 +196,10 @@ describe("getSignedUrl", () => {
     });
   });
 
-  it("should throw if presign request with MRAP ARN and disableMultiregionAccessPoints option", () => {
+  it("should throw if presign request with MRAP ARN and disableMultiregionAccessPoints option", async () => {
     const mockPresigned = "a presigned url";
     vi.mocked(mockS3RequestPresigner.presign).mockReturnValue(mockPresigned as any);
+
     const client = new S3Client({
       ...clientParams,
       disableMultiregionAccessPoints: true,
@@ -207,13 +208,9 @@ describe("getSignedUrl", () => {
       Bucket: "arn:aws:s3::123456789012:accesspoint:mfzwi23gnjvgw.mrap",
       Key: "Key",
     });
-    return expect(getSignedUrl(client, command)).rejects.toEqual(
-      new (class EndpointError extends Error {
-        constructor(...args: any[]) {
-          super(...args);
-          this.name = "EndpointError";
-        }
-      })("Invalid configuration: Multi-Region Access Point ARNs are disabled.")
-    );
+
+    const error = await getSignedUrl(client, command).catch((e) => e);
+    expect(error.name).toEqual("EndpointError");
+    expect(error.message).toEqual("Invalid configuration: Multi-Region Access Point ARNs are disabled.");
   });
 });

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ describe(updateDiscoveredEndpointInCache.name, () => {`
`117`	`117`	`The operation to discover endpoint failed.` +
`118`	`118`	` Please retry, or provide a custom endpoint and disable endpoint discovery to proceed.`
`119`	`119`	`),`
`120`		`- { reason: error }`
	`120`	`+ { reason: new Error("rejected") }`
`121`	`121`	`)`
`122`	`122`	`);`
`123`	`123`	`}`