Fix first part response validation in parallel presigned URL multipart subscriber#7013
Merged
Conversation
a93db33 to
d39cda4
Compare
zoewangg
reviewed
Jun 9, 2026
| if (isCompletedExceptionally.get()) { | ||
| handlePartError(error, 0); | ||
| if (downloadFailed.get()) { | ||
| return; |
Contributor
There was a problem hiding this comment.
Question: any reason we removed handlePartError(error, 0); from here?
Contributor
Author
There was a problem hiding this comment.
Yes, at this point error is null, we return early if error != null. So handlePartError(error, 0); would have been no-op, hence removed it. If downloadFailed is already set, another thread handled the real error, we just return early.
Comment on lines
+181
to
+182
| "Content-Range mismatch for part " + partIndex + ". Expected start byte: " + expectedStartByte | ||
| + ", but got: bytes " + actualStartByte + "-" + actualEndByte)); |
Contributor
There was a problem hiding this comment.
Nit: can we use String.format for better readability? same for other exception messages
zoewangg
approved these changes
Jun 9, 2026
ba83697 to
515de9f
Compare
515de9f to
bf99b11
Compare
…pre-signed-url-getobject/parallel-subscriber-validation
ba66c7b
into
feature/master/pre-signed-url-getobject
3 of 4 checks passed
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
ParallelPresignedUrlMultipartDownloaderSubscriberdid not validate the first part's response metadata (Content-Length, Content-Range alignment). Parts 1+ were validated via validatePartResponse(), but part 0 only checked whether Content-Range was parseable — it never verified that the returned byte range and content length matched expectations.PresignedUrlMultipartDownloaderSubscriberhad a misleading counter namedcompletedPartsthat was actually used as a part index assignment counter (incremented before the request, not after completion)Modifications
Also renamed isCompletedExceptionally → downloadFailed for clarity and to avoid confusion with
java.util.concurrent.CompletableFuture.isCompletedExceptionally().Separated error != null and downloadFailed.get() checks in sendPartRequest to avoid passing null to handlePartError. Added debug log for late completions.
[CompletableFutureUtils.forwardExceptionTo(resultFuture, response)](https://github.com/aws/aws-sdk-java-v2/pull/7013/changes#diff-eb746928a00e747ec260988bb77481373a53af2e2c11bc2918563b05ff11dd5aR143)in sendFirstRequest for consistency with sendPartRequest — ensures part 0 is cancelled if the download is cancelled externally.PresignedUrlDownloadHelper.Moved calculateTotalParts() to MultipartDownloadUtils.
MultipartDownloadUtils.parseContentRange().Removed parseStartByteFromContentRange (now redundant). Validates both start byte and end byte numerically.
Improved error message to include part index and actual vs expected byte ranges.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License