Add property to disable Put MD5 validation #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could also change the property to be more generic since object stores which do not return MD5 ETag for put also do not return it for get or copy. |
gaul
force-pushed
the
disable-put-object-md5-validation
branch
from
a8cce14 to
b21ff8a
Compare
Some object stores like S3Proxy with the Azure backend do not return the MD5 sum for ETag. Fixes gaul/s3proxy#96.
gaul
force-pushed
the
disable-put-object-md5-validation
branch
from
b21ff8a to
df98496
Compare
|
Change looks good to me. Can you confirm you are submitting under the apache 2.0 license? |
|
Confirmed that I submit this change under the Apache 2.0 license. |
|
Thanks! I've staged this internally, just waiting for approval from legal and I'll get this merged in. |
shorea
added a commit
that referenced
this pull request
Nov 30, 2015
…tion Add property to disable Put MD5 validation
|
Merged. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some object stores like S3Proxy with the Azure backend do not return
the MD5 sum for ETag. Fixes gaul/s3proxy#96.