GH-65 Fix "Paramters" typo#66
Merged
Merged
Conversation
Contributor
Author
|
Sorry, my bad, this almost duplicates #54, although I found and fixed one more occurrence in comments. |
Contributor
|
Thanks for the fix. (de)serialization doesn't seem to be impacted by the typos, however, it would be preferable to keep the existing methods with the typos for backwards compatibility, mark them as deprecated, and add two new methods with the fixes. |
- keep the old methods for backward compatibility (marked as @deprecated) - ignore folder with maven build results and IDEA-specific metadata
Contributor
Author
|
Thanks for feedback, you're right - it's safer to keep backward compatibility this way. Updated & force-pushed. Also slightly updated |
maxday
added a commit
that referenced
this pull request
Jun 28, 2024
M-Elsaeed
pushed a commit
that referenced
this pull request
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #65
Fixed a typo in method's naming, also did a search and fixed the same in a couple of comments.
Warning: as existing API methods are renamed, it's a breaking change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.