fix(test): correctly invoke ec.generate_private_key#585
Merged
texastony merged 2 commits intoaws:masterfrom Jun 6, 2023
Merged
fix(test): correctly invoke ec.generate_private_key#585texastony merged 2 commits intoaws:masterfrom
texastony merged 2 commits intoaws:masterfrom
Conversation
It takes a curve instance, not a curve class
texastony
approved these changes
Jun 5, 2023
texastony
changed the title
texastony
previously requested changes
Jun 5, 2023
Contributor
texastony
left a comment
texastony
left a comment
There was a problem hiding this comment.
@alex
Thanks for the PR.
Unfortunately, the commit message fails our Semantic PR check.
Can you push another commit empty commit with the following message:
fix(test): correctly invoke ec.generate_private_key
That should pass the check and we should be able to merge this.
(You can make an Empty commit via: git commit --allow-empty)
Contributor
Author
|
done |
texastony
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It takes a curve instance, not a curve class
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: