docs: Add Thread safety section to README#562
Merged
texastony merged 6 commits intoaws:masterfrom Feb 24, 2023
gliptak:patch-1
Merged
docs: Add Thread safety section to README#562texastony merged 6 commits intoaws:masterfrom gliptak:patch-1
texastony merged 6 commits intoaws:masterfrom
gliptak:patch-1
Conversation
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
gliptak
changed the title
Closed
texastony
reviewed
Feb 21, 2023
Contributor
texastony
left a comment
texastony
left a comment
There was a problem hiding this comment.
Thank you for cutting this PR!
I left two suggestions.
I will approve if they or something like them is committed.
Unless you find my suggestions more confusing then the original,
in which case, respond with a comment and we can try again.
Co-authored-by: Tony Knapp <5892063+texastony@users.noreply.github.com>
Co-authored-by: Tony Knapp <5892063+texastony@users.noreply.github.com>
Contributor
Author
|
@texastony thank you for rewording. Your edits clarified some angles so I merged them |
texastony
reviewed
Feb 22, 2023
Contributor
texastony
left a comment
texastony
left a comment
There was a problem hiding this comment.
Issue/Suggestion:
Oh no!
I messed up all the links and other formatting.
I thought this was a Mark Down file... but it's an rst file.
I have made a suggestion that replaces MD formatting with rst formatting.
I am very sorry about this back forth.
texastony
previously approved these changes
Feb 23, 2023
texastony
approved these changes
Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#560 #11 (comment)
Description of changes:
Add Thread safety section to README
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: