Pin build dependencies and configure dependabot (#389) #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: Pin build dependencies and configure dependabot * Ignore flake8 document linting on tests * Unpin decrypt_oracle dependencies for now * Pin tox * Isolate pinned dependencies to dev_requirements dir
texastony
previously approved these changes
Dec 17, 2021
texastony
dismissed
their stale review
We need to regenerate these files with python2.7 passing...
Contributor
Author
|
Yup, hadn't considered how Python 2.7 would affect things. We need to consider how to handle dependencies with python2.7. Potentially we can pin dependencies for python 2.7 separately so they are not targeted by dependabot. Alternatively, we could consider just pinning all of them and don't target this branch for dependabot. I need to consider what the best support path for these older branches is. |
Contributor
|
We can talk it over with the team, but I think a version in maintenance can have pinned dependencies that do not update, or only update for security events. |
Contributor
Author
|
closing in favor of #397 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Pin build dependencies and configure dependabot
Ignore flake8 document linting on tests
Unpin decrypt_oracle dependencies for now
Pin tox
Isolate pinned dependencies to dev_requirements dir
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: