chore: pin dependencies and enable dependabot #388
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "pip" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "daily" | ||
| - package-ecosystem: "pip" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "daily" | ||
| target-branch: "mainline-1.x" | ||
| - package-ecosystem: "pip" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "daily" | ||
| target-branch: "mainline-2.x" | ||
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "daily" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| boto3==1.20.24 | ||
| cryptography==36.0.1 | ||
| attrs==21.2.0 | ||
| wrapt==1.13.3 | ||
|
Comment on lines
-1
to
+4
Contributor
There was a problem hiding this comment. I think that this is a bad idea. Why? Our customers now cannot use different versions of these dependencies in their environments. I recommend reverting the changes in this file.
Comment on lines
-1
to
+4
Contributor
There was a problem hiding this comment. I think that this is a bad idea. Why? Our customers now cannot use different versions of these dependencies in their environments. I recommend reverting the changes in this file. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,11 @@ | ||
| mock==4.0.0 | ||
| pytest==6.2.5 | ||
| pytest-cov==3.0.0 | ||
| pytest-mock==3.6.0 | ||
|
|
||
| bandit==1.7.1 | ||
| doc8==0.10.1 | ||
| flake8==4.0.1 | ||
| pylint==2.12.2 | ||
| black==21.12b0 | ||
| isort==5.10.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know if dependabot will make recommendations for any requirements file? Or will it only think about the requirements file in root directory and ignore
test/requirements.txt?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll look at any requirements file, it's the same way with the ddbec-java repo. There are two pom.xml files, one in the root and one in sdk1/