Open
Conversation
MSilva98
reviewed
Jun 27, 2025
Co-authored-by: Marco Silva <masilva1998@hotmail.com>
Pimenta14
approved these changes
Jun 30, 2025
MSilva98
approved these changes
Jun 30, 2025
Author
|
@mattsb42-aws Please look into this ! |
|
Looks like this was already committed manually to the master branch. |
Contributor
|
Adding this upper bound is not actually a fix and ends up causing downstream problems (ref #263 and #267) In general, adding upper bound constraints to a Python library causes more breakage than it fixes, as explained here https://iscinumpy.dev/post/bound-version-constraints/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added max supported version of lxml
After the recent release of lxml connector started to throw error, so added a max allowed version
Motivation and Context
For best codes to not fail suddenly, this is a best practice
#263