Fix: force timeouts to integer types#226
Open
andrewargeros wants to merge 6 commits intoaws:masterfrom
Open
Conversation
Author
|
@Brooke-white not sure what the best way to request review on this is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
literally just 2
int()casts for various cases wheretimeoutandidp_response_timeoutare read in as strings, but should be integersMotivation and Context
Since sqlalchemy (and other packages) force url parameters to be passed as strings to redshift_connector, we can run into basic and avoidable issues from this package when connecting to Redshift via SQLAlchemy via the
BrowserAzureOAuth2CredentialsProvidermethod.Testing
Built package, connected, fixed the bug.
Screenshots (if appropriate)
code to reproduce:
Types of changes
Checklist
./build.shsucceedspytest test/unitand they are passing.