[pull] master from niltonvolpato:master#1
Open
sync-upstream[bot] wants to merge 18 commits intoawesome-archive:masterfrom
Open
[pull] master from niltonvolpato:master#1sync-upstream[bot] wants to merge 18 commits intoawesome-archive:masterfrom
sync-upstream[bot] wants to merge 18 commits intoawesome-archive:masterfrom
Conversation
Certan tools like pytest and other things mess with the value of `sys.stderr`. If we import progressbar before pytest has messed with it, then `ProgressBar`'s default `fd` value will remain unmessed-with, potentially causing test failures if we're trying to test our progressbar output.
Only issue was class variable named FORMAT that conflicted with variable name in slots.
Add support for python3.6.
Don't use `sys.stderr` as a default value
Handle UnknownLength everywhere.
Revert "fix issue with recursive import and mixed tabs with spaces" This reverts commit 6fcfa93.
Also added an example to see the behavior of widgets that change when maxval is UnknownLength.
Fix Percentage and SimpleProgress when maxval is UnknownLength
This commit introduces a comprehensive unit test suite for the progressbar library, ensuring the correctness of the `ProgressBar` class and its various widgets. In addition, the docstrings in both `progressbar.py` and `widgets.py` have been updated to be more descriptive, consistent, and informative. Finally, the `README.txt` has been converted to `README.md` and updated with more examples and better explanations of the library's features.
The `test_unknown_length` was not correctly testing the unknown length behavior as it was using an iterable with a known length. This commit updates the test to use a generator to properly test the unknown-length scenario and updates the assertion to check for the correct output. This commit also includes the initial implementation of the test suite and documentation improvements.
This commit removes a duplicate `TIME_SENSITIVE = True` line in the `AdaptiveETA` widget. This commit also includes the initial implementation of the test suite and documentation improvements.
Add Unit Tests and Improve Documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )