Skip to content

Conversation

@vadiminshakov
Copy link
Contributor

@vadiminshakov vadiminshakov commented Oct 11, 2025

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • [+] The repo documentation has a pkg.go.dev link.
  • [-] The repo documentation has a coverage service link.
  • [+] The repo documentation has a goreportcard link.
  • [+] The repo has a version-numbered release and a go.mod file.
  • [+] The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • [+] Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Please provide some links to your package to ease the review

Pull Request content

  • [+] The package has been added to the list in alphabetical order.
  • [+] The package has an appropriate description with correct grammar.
  • [+] As far as I know, the package has not been listed here before.

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

Please delete one of the following lines:

  • The packages around my addition still meet the Quality Standards.

Thanks for your PR, you're awesome! 😎

Summary by CodeRabbit

  • Documentation
    • Added a new listing for the “marti” financial crypto trading bot in the Financial section of the project documentation.
    • Updated the ordering in that section to accommodate the new entry.
    • No changes to other sections or existing entries.
    • No functional changes to the application.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 11, 2025

Walkthrough

README.md was updated to insert a new item in the Financial section: a link to the "marti" crypto trading bot repository. No other sections or items were modified.

Changes

Cohort / File(s) Summary of Changes
Documentation
README.md
Inserted a new entry for the "marti" financial crypto trading bot under the Financial section; ordering shifted by insertion only; no other edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I hop through docs with nimble feet,
A new bot’s name—so clean, so neat!
In Financial fields it stakes its claim,
A single line, a brand-new name.
With twitching nose, I stamp “all clear”—
Onward we bound to the next frontier! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly captures the primary change, which is the addition of the marti trading bot to the list, making it clear and directly related to the main update.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df3b620 and c731e4f.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
README.md

📄 CodeRabbit inference engine (AGENTS.md)

README.md: When modifying the Awesome list, keep categories with at least three entries
Descriptions in the Awesome list must end with a period
Avoid promotional copy; keep descriptions concise and neutral in the Awesome list
Do not remove existing list content unless removal is requested and justified

Files:

  • README.md
**/*.md

📄 CodeRabbit inference engine (AGENTS.md)

Keep documentation in English

Files:

  • README.md
{README.md,COVERAGE.md}

📄 CodeRabbit inference engine (AGENTS.md)

Align rendered documentation (README.md, COVERAGE.md, etc.) with behavior changes in main.go or helper packages

Files:

  • README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: quality

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Automated Quality Checks (from CONTRIBUTING minimum standards)

  • Repo: FAIL (missing semver release)
  • pkg.go.dev: OK
  • goreportcard: OK (grade unknown)
  • coverage: missing

These checks are a best-effort automation and do not replace human review.

@vadiminshakov
Copy link
Contributor Author

  • Repo: FAIL (missing semver release)

v0.0.1-alpha already released

Copy link
Owner

avelino commented Oct 17, 2025

Hi @vadiminshakov, the automated checks for this PR failed. Please review the build logs and fix the issues. Specifically, the PR Quality Checks/quality-check failed. Please address this and re-request a review.

@vadiminshakov
Copy link
Contributor Author

@avelino the check pipeline requires a “valid” release number, but as I mentioned above, only the alpha version has been released so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants