DYN-10011: Return runtime concrete type for types implementing .NET interfaces#5
Closed
aparajit-pratap wants to merge 10 commits intoautodesk-forks:dynamo_py3from
Closed
DYN-10011: Return runtime concrete type for types implementing .NET interfaces#5aparajit-pratap wants to merge 10 commits intoautodesk-forks:dynamo_py3from
aparajit-pratap wants to merge 10 commits intoautodesk-forks:dynamo_py3from
Conversation
|
Is it feasible to add a test for this? |
aparajit-pratap
commented
Jan 9, 2026
Author
I know how to add a test for this in Dynamo. Will explore how I can add a test to this project. |
twastvedt
approved these changes
Jan 12, 2026
twastvedt
left a comment
twastvedt
left a comment
There was a problem hiding this comment.
Looks like test CI needs some attention, but if this runs locally, looks good to me.
Author
|
|
Author
|
Closing in favor of #6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Background: When a .NET method returns a concrete type that implements an interface, e.g.
IDisposable, pythonnet incorrectly resolves the object as the interface type instead of the concrete type. This prevents access to the concrete type's members and breaks common patterns using Python's with statement for resource management with IDisposable types.This PR attempts to fix the above issue.
Does this close any currently open issues?
...
Any other comments?
Reviewers:
@zeusongit
@twastvedt
@zavub
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG