Changes recommended to get the CircleCI emblem to go green#384
Open
djbauch wants to merge 47 commits intoauth0-samples:masterfrom
Open
Changes recommended to get the CircleCI emblem to go green#384djbauch wants to merge 47 commits intoauth0-samples:masterfrom
djbauch wants to merge 47 commits intoauth0-samples:masterfrom
Conversation
Author
|
I learned enough about CircleCI and codeceptjs to get the pipeline to work. It required a few more changes than I had expected, and some of those changes are in the SPA Quickstart Tests project. I'll put another PR in there. In the meantime, I'm running the tests from my fork. It now works correctly, but it doesn't use puppeteer anymore. It just uses playwright. I couldn't get puppeteer to configure correctly for operation with the chrome and firefox browsers. Here's the snapshot from CircleCI now: |
Snyk has created this PR to upgrade @babel/core from 7.26.10 to 7.27.1. See this package in yarn: @babel/core See this project in Snyk: https://app.snyk.io/org/djbauch/project/0c21a7a9-9bac-4947-a5b5-f36ebd0e2d19?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade @babel/plugin-transform-react-jsx from 7.25.9 to 7.27.1. See this package in yarn: @babel/plugin-transform-react-jsx See this project in Snyk: https://app.snyk.io/org/djbauch/project/0c21a7a9-9bac-4947-a5b5-f36ebd0e2d19?utm_source=github&utm_medium=referral&page=upgrade-pr
…5905d078de3 [Snyk] Upgrade @babel/plugin-transform-react-jsx from 7.25.9 to 7.27.1
…7d770f5dd5a [Snyk] Upgrade @babel/core from 7.26.10 to 7.27.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the CI configuration, Dockerfile, server and API server files, and several React components within the
Sample-01project. The changes aim to update dependencies, improve code readability, and enhance the UI.CI and Docker Updates:
.circleci/config.ymlto22.4.0although I don't think I did it in the most efficient way and Docker version to20.10.24. [1] [2]Sample-01/Dockerfileto use build arguments for Node.js and Alpine versions, and added cleanup for APK cache. [1] [2]Server and API Server Changes:
Sample-01/api-server.jsandSample-01/server.js. [1] [2]authmiddleware configuration inSample-01/api-server.jsto usetokenSigningAlginstead ofalgorithms.Dependency Updates:
Sample-01/package.json, including@auth0/auth0-reactandexpress-oauth2-jwt-bearer. Addedreact-json-viewand specified Yarn as the package manager. [1] [2]React Component Improvements:
Highlightcomponent withreact-json-viewfor JSON rendering inExternalApi.jsandProfile.js. [1] [2]classNameinExternalApi.jsfor React compatibility. [1] [2]npm run devtoyarn run devinExternalApi.js.Rationale:
These changes have to do with the CircleCI configuration file and the Dockerfile, not just the code itself. I am able to get CircleCi to run everything except the integration tests. Even without accepting changes to the source that I recommend, you might get a green CircleCI emblem just with the changes to those two configuration files.
I also updated the package.json file to get the newer versions of the Auth0 react and bearer packages. All of that should be sufficient to get up to the Run integration tests stage of the CircleCI pipeline. I don't yet have any familiarity with codecept, so I didn't even attempt to fix that.
In api_server.js, I just made some simple changes to avoid type confusion with the environment variables and fixed the third argument to the call to auth(). I also made the variables used in server.js always be strings as well. These changes were primarily to support work that isn't reflected here, since I am working on a Vite/TypeScript/Vitetest/ReactRouter7 variation of the example. These changes won't alter the behavior of the application, since the default value for the argument to auth() is being redundantly specified in either case.
The other changes I made were to get rid of the bespoke Highlight component and replace it with a component from npmjs. I did this to eliminate warnings related to the rendering of stringified JSON by the Highlight component.