Expose errors from the API endpoint in the UI#329
Open
ewanharris wants to merge 3 commits intomasterfrom
Open
Conversation
ewanharris
force-pushed
the
feat/surface-api-errors
branch
from
adaf015 to
5778c17
Compare
| apiError | ||
| }); | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
I'm wondering if this isnt a bit too much for anyone using the sample to try and understand how to use our SDK. I know this isnt necessary related to our SDK, but not everyone might understand that.
In what event do we get back non-json?
Contributor
Author
There was a problem hiding this comment.
Yeah I realise now this is probably too much for the sample, the only case that raw HTML would be returned is when the server errors with something other than a token error. So maybe in that instance we can just ignore?
Contributor
There was a problem hiding this comment.
I would argue we could abstract this in a component? That way it's all at least seperated from basic integration?
mchang16-auth
pushed a commit
to mchang16-auth/auth0-react-samples
that referenced
this pull request
Feb 27, 2025
…m_and_yarn/Sample-01/angular/language-service-15.1.0 Bump @angular/language-service from 15.0.0 to 15.1.0 in /Sample-01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We could potentially extend this to also include examples of how to fix these issues.
For example:
The
audienceis different between the frontend and backendA developer extends this sample to include
requiredScopesbut does not update the frontend/update their token