Skip to content

[SDK-3196] Rewrite with Authlib rather than python-jose#58

Closed
adamjmcgrath wants to merge 1 commit intomasterfrom
pyvnext-rewrite
Closed

[SDK-3196] Rewrite with Authlib rather than python-jose#58
adamjmcgrath wants to merge 1 commit intomasterfrom
pyvnext-rewrite

Conversation

@adamjmcgrath
Copy link
Copy Markdown

Authlib 0.x provides middleware that protects Flask APIs with https://datatracker.ietf.org/doc/html/rfc6750 - so we can remove all the code that gets the Bearer Token and Issues spec compliant errors.

When Authlib 1.x is released we can remove validator.py as this will include it's own JWTBearerValidator

@adamjmcgrath adamjmcgrath added the large Large review label Mar 10, 2022
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner March 10, 2022 15:02
@adamjmcgrath adamjmcgrath added review:large Large review and removed large Large review labels Mar 10, 2022
@adamjmcgrath adamjmcgrath changed the title Rewrite with Authlib rather than python-jose [SDK-3196] Rewrite with Authlib rather than python-jose Mar 10, 2022
@adamjmcgrath adamjmcgrath added review:medium Medium review and removed review:large Large review labels Mar 10, 2022
evansims
evansims previously approved these changes Mar 11, 2022
@adamjmcgrath adamjmcgrath marked this pull request as ready for review March 16, 2022 14:44
@adamjmcgrath
Copy link
Copy Markdown
Author

Added some unit tests because I had some around anyway and was able to reduce the validator code because Authlib 1.0 is out

@adamjmcgrath adamjmcgrath requested a review from evansims March 16, 2022 14:45
Copy link
Copy Markdown

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice work!

@adamjmcgrath
Copy link
Copy Markdown
Author

Am going to leave this in draft mode for a bit so I can point the old QS to master and the new QS to this

@adamjmcgrath adamjmcgrath marked this pull request as draft March 17, 2022 11:57
@stale
Copy link
Copy Markdown

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

@stale stale bot added the closed:stale Issue or PR has not seen activity recently label Jul 10, 2022
@Widcket Widcket removed the closed:stale Issue or PR has not seen activity recently label Jul 10, 2022
Copy link
Copy Markdown

@jaskaranxsingh jaskaranxsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stale
Copy link
Copy Markdown

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

@stale stale bot added the closed:stale Issue or PR has not seen activity recently label May 21, 2023
@stale stale bot closed this Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed:stale Issue or PR has not seen activity recently review:medium Medium review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants