Conversation
gkwang
left a comment
gkwang
left a comment
There was a problem hiding this comment.
Can we update this as well:
node-xml-encryption/package.json
Line 35 in 291f3f1
|
nit: Also do we still want to keep the package-lock file since this is a library and considering it was removed in the previous PR? |
Also updates package lock file to version 2; backwards compatible to version 1
esarafianou
force-pushed
the
release_v2
branch
from
d3f577e to
77ccf3b
Compare
|
@gkwang was the package-lock file ever removed? Based on it's history here: https://github.com/auth0/node-xml-encryption/commits/master/package-lock.json, it's been around since Jan 2020. |
|
My 2 cents since I'm around ;) having or not a package lock is a recurring debate in npm modules. It can still make sense to lock the dependencies of libraries, if only for the dev ones, as it makes CI build more reproducible (ie the build won't start failing when there is no change in the repository). The lock will have no impact on the users of the library as it's not included in the package, and they should do their own locking |
gkwang
left a comment
gkwang
left a comment
There was a problem hiding this comment.
Sounds good. I think we can leave the package-lock around to make some of our tools happy.
4 participants
Description