Update node-forge to the latest version#76
Merged
esarafianou merged 2 commits intomasterfrom Sep 9, 2020
Merged
Conversation
gkwang
approved these changes
Sep 8, 2020
gkwang
requested changes
Sep 8, 2020
Contributor
gkwang
left a comment
gkwang
left a comment
There was a problem hiding this comment.
wait, why did the package-lock got changed to http?
added 2 commits
September 8, 2020 20:12
Updating it addresses a secuity issue: https://snyk.io/vuln/SNYK-JS-NODEFORGE-598677
esarafianou
force-pushed
the
update_forge
branch
from
c38585a to
9b6df94
Compare
Contributor
Author
|
@gkwang Not sure what went wrong with the |
gkwang
approved these changes
Sep 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
node-forgeto the latest version to address a security issue in the dependency and bumps a new version. Fixes #75The
node-forgenew version drops support for node 4 butnode-xml-encryptionalready specifies the node engine >=8. As such, a new patch version will be released.References
https://snyk.io/vuln/SNYK-JS-NODEFORGE-598677
Testing
All tests pass successfully.
Checklist
master