Make sure that Node 6-8 is supported#41
Merged
Conversation
gnarea
commented
Feb 26, 2018
| }; | ||
|
|
||
| crypto.randomBytes(32, function(err, randomBytes) { | ||
| var plaintext = 'The quick brown fox jumps over the lazy dog'; |
Contributor
Author
There was a problem hiding this comment.
I think it's best to test this with a constant value that we can check across versions of Node.
gnarea
commented
Feb 26, 2018
| @@ -182,15 +182,10 @@ function decryptKeyInfo(doc, options) { | |||
| } | |||
|
|
|||
| function decryptKeyInfoWithScheme(encryptedKey, options, scheme) { | |||
Contributor
Author
There was a problem hiding this comment.
This is the function I was concerned could be problematic in Node 6. This change is not strictly necessary, I just happened to notice it whilst reviewing it.
Contributor
Author
|
I just noticed that the build failed on Node 0.10 only, for reasons unrelated to my change, so maybe we should drop support for it? |
|
The failure seems to be in mocha usage, last master execution run with mocha@3.3.0, your run with mocha@5.0.1. Can you set a fixed version of mocha: https://github.com/auth0/node-xml-encryption/blob/master/package.json#L5 ? |
This was referenced Nov 16, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to make sure that Node 6 and 8 are supported today, and as future changes are introduced.
Given the changes to the default encoding in the cryptographic functions introduced in Node 6, I wasn't sure if
xmlenc.decryptKeyInfo()worked properly in Node 6.