fix: update jws to 4.0.0 to resolve SlowBuffer deprecation#1001
Open
l7aromeo wants to merge 2 commits intoauth0:masterfrom
Open
fix: update jws to 4.0.0 to resolve SlowBuffer deprecation#1001l7aromeo wants to merge 2 commits intoauth0:masterfrom
l7aromeo wants to merge 2 commits intoauth0:masterfrom
Conversation
Dependency chain issue: - jsonwebtoken → jws 3.2.2 → jwa 1.4.1 → buffer-equal-constant-time - buffer-equal-constant-time uses SlowBuffer (removed in Node.js 25) - jwa 1.4.2+ replaced buffer-equal-constant-time with crypto.timingSafeEqual - jws 4.0.0 includes jwa 2.0.0 which has the fix
|
+1 |
|
Just to rephrase: Node.js doesn't deprecate SlowBuffer, it completely removes it, meaning apps on Node 25 will crash. It would be good to have a look at this PR, given how slow deps updates flow through the ecosystem, and given that |
ork-acro
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
jwsdependency from 3.2.2 to 4.0.0 to resolve compatibility issues with Node.js 25+, where theSlowBufferconstructor has been removed.Problem:
The current dependency chain includes an outdated version of
jwa(1.4.1) that depends onbuffer-equal-constant-time, which uses the deprecatedSlowBufferAPI. This causes the library to crash on Node.js 25 with the error:Solution:
Updating
jwsto 4.0.0 brings injwa2.0.0, which replacedbuffer-equal-constant-timewith Node.js's nativecrypto.timingSafeEqual()method (introduced in jwa 1.4.2).Dependency chain:
Compatibility:
This is a non-breaking change as
jws4.0.0 maintains API compatibility with 3.x.References
Testing
Manual Testing:
Test Commands:
Environment:
Checklist