Merged
Conversation
Current coverage is 84.00% (diff: 100%)@@ master #71 diff @@
==========================================
Files 13 13
Lines 400 400
Methods 0 0
Messages 0 0
Branches 57 57
==========================================
Hits 336 336
Misses 51 51
Partials 13 13
|
Contributor
Author
|
I am also fixing the commons-io entry to remove a maven warning |
adrogon
approved these changes
Sep 27, 2016
adrogon
left a comment
adrogon
left a comment
There was a problem hiding this comment.
I agree with the upgrade of commons-codec, which would be very welcome.
About commons-io, upgrade to 2.5 could be tried, but of course the groupId change is already an improvement so can be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #69.