Change group name for commons-io dependency#68
Closed
leifbladt wants to merge 1 commit intoauth0:masterfrom
leifbladt:master
Closed
Change group name for commons-io dependency#68leifbladt wants to merge 1 commit intoauth0:masterfrom leifbladt:master
leifbladt wants to merge 1 commit intoauth0:masterfrom
leifbladt:master
Conversation
Current coverage is 83.25% (diff: 100%)@@ master #68 diff @@
==========================================
Files 13 13
Lines 400 400
Methods 0 0
Messages 0 0
Branches 57 57
==========================================
Hits 333 333
Misses 53 53
Partials 14 14
|
Author
|
The real problem seems to be, that the http://central.maven.org/maven2/com/auth0/java-jwt/2.2.0/java-jwt-2.2.0.pom: <dependencies>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-io</artifactId>
<version>1.3.2</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.12</version>
<scope>test</scope>
<exclusions>
<exclusion>
<artifactId>hamcrest-core</artifactId>
<groupId>org.hamcrest</groupId>
</exclusion>
</exclusions>
</dependency>
</dependencies>local dependency-reduced-pom.xml: <dependencies>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.12</version>
<scope>test</scope>
<exclusions>
<exclusion>
<artifactId>hamcrest-core</artifactId>
<groupId>org.hamcrest</groupId>
</exclusion>
</exclusions>
</dependency>
</dependencies> |
Contributor
|
Incidentally I did the same just now in #71 - and a bit more. Big troubles in our builds due to this commons-io with the wrong name. And too damn long to merge PRs make people waste time. |
Contributor
|
Closed in favor on #71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
commons-iodependency changed the group id, so I updated the dependency to the new one.Background is, that we ran into some problems with Gradle and Eclipse, because of these relocation section in the original
pom.xml.