Add support for organizations feature #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
requested changes
Mar 25, 2021
Contributor
stevehobbsdev
left a comment
stevehobbsdev
left a comment
There was a problem hiding this comment.
Looks great! Just left a couple of minor comments.
README.rst
Outdated
|
|
||
| client.authorize(client_id='client_id', | ||
| redirect_uri='http://localhost', | ||
| invitation="invitation_123") |
Contributor
There was a problem hiding this comment.
The section here describes logging into an Organization but the example is for invitations - typo?
Contributor
Author
There was a problem hiding this comment.
Good catch, new commit pushed to fix.
README.rst
Outdated
| Accept user invitations | ||
| ----------------------- | ||
|
|
||
| Accept a user invitation by specifying the ``invitation`` property when calling ``authorize()``. Note that you must also specify the ``organization`` if providing an ``invitation``: |
Contributor
There was a problem hiding this comment.
Let's also add in here where the organization and invitation values come from when accepting user invitations, and that the developer should inspect the invitation URL for these params, perhaps with a short example of how to parse that in Python (I'll leave that up to you).
Contributor
Author
There was a problem hiding this comment.
Added info about the invitation URL and the params, similar to the .NET API docs.
stevehobbsdev
approved these changes
Mar 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for the (beta) Organizations and User Invitations features. Changes included:
AuthorizeClient.org_idclaim inTokenVerifierTesting
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist