Merge branch '3.1.x' into 3.2.x

Nicofuma · Nicofuma · commit 7bb4e88acdb0 · 2016-10-03T20:20:54.000+02:00
* 3.1.x:
  [ticket/14802] Add test for empty/blank lines in poll options
  [ticket/14802] Empty/blank lines should not be additional poll options
diff --git a/phpBB/includes/message_parser.php b/phpBB/includes/message_parser.php
@@ -1860,7 +1860,7 @@ function parse_poll(&$poll)
 		// Parse Poll Option text
 		$tmp_message = $this->message;
 
-		$poll['poll_options'] = explode("\n", trim($poll['poll_option_text']));
+		$poll['poll_options'] = preg_split('/\s*?\n\s*/', trim($poll['poll_option_text']));
 		$poll['poll_options_size'] = sizeof($poll['poll_options']);
 
 		foreach ($poll['poll_options'] as &$poll_option)
diff --git a/tests/functional/posting_test.php b/tests/functional/posting_test.php
@@ -159,6 +159,22 @@ public function test_quote_depth_submit()
 		}
 	}
 
+	public function test_post_poll()
+	{
+		$this->login();
+
+		$post = $this->create_topic(
+			2,
+			'[ticket/14802] Test Poll Option Spacing',
+			'Empty/blank lines should not be additional poll options.',
+			array('poll_title' => 'Poll Title', 'poll_option_text' => "\n A \nB\n\nC \n D\nE\n\n \n")
+		);
+
+		$crawler = self::request('GET', "viewtopic.php?t={$post['topic_id']}&sid={$this->sid}");
+		$this->assertEquals('Poll Title', $crawler->filter('.poll-title')->text());
+		$this->assertEquals(5, $crawler->filter('*[data-poll-option-id]')->count());
+	}
+
 	protected function set_quote_depth($depth)
 	{
 		$crawler = self::request('GET', 'adm/index.php?sid=' . $this->sid . '&i=acp_board&mode=post');
