[ticket/13941] Workaround to fix the bug on php 5.5 with sqlite3

Tristan Darricau · Tristan Darricau · commit 5dbfd146992b · 2015-06-13T13:20:55.000+02:00
PHPBB3-13941
diff --git a/phpBB/phpbb/tree/nestedset.php b/phpBB/phpbb/tree/nestedset.php
@@ -837,7 +837,10 @@ public function regenerate_left_right_ids($new_id, $parent_id = 0, $reset_ids =
 				' . $this->get_sql_where('AND') . '
 			ORDER BY ' . $this->column_left_id . ', ' . $this->column_item_id . ' ASC';
 		$result = $this->db->sql_query($sql);
-		while ($row = $this->db->sql_fetchrow($result))
+		$rows = $this->db->sql_fetchrowset($result);
+		$this->db->sql_freeresult($result);
+
+		foreach ($rows as $row)
 		{
 			// First we update the left_id for this module
 			if ($row[$this->column_left_id] != $new_id)
@@ -862,7 +865,6 @@ public function regenerate_left_right_ids($new_id, $parent_id = 0, $reset_ids =
 			}
 			$new_id++;
 		}
-		$this->db->sql_freeresult($result);
 
 		if ($acquired_new_lock)
 		{

Original file line number	Diff line number	Diff line change
`@@ -837,7 +837,10 @@ public function regenerate_left_right_ids($new_id, $parent_id = 0, $reset_ids =`
`837`	`837`	`' . $this->get_sql_where('AND') . '`
`838`	`838`	`ORDER BY ' . $this->column_left_id . ', ' . $this->column_item_id . ' ASC';`
`839`	`839`	`$result = $this->db->sql_query($sql);`
`840`		`- while ($row = $this->db->sql_fetchrow($result))`
	`840`	`+ $rows = $this->db->sql_fetchrowset($result);`
	`841`	`+ $this->db->sql_freeresult($result);`
	`842`	`+`
	`843`	`+ foreach ($rows as $row)`
`841`	`844`	`{`
`842`	`845`	`// First we update the left_id for this module`
`843`	`846`	`if ($row[$this->column_left_id] != $new_id)`
`@@ -862,7 +865,6 @@ public function regenerate_left_right_ids($new_id, $parent_id = 0, $reset_ids =`
`862`	`865`	`}`
`863`	`866`	`$new_id++;`
`864`	`867`	`}`
`865`		`- $this->db->sql_freeresult($result);`
`866`	`868`
`867`	`869`	`if ($acquired_new_lock)`
`868`	`870`	`{`