- Allow charset names containing underscores or spaces

naderman · naderman · commit 56a1db7d7bf8 · 2007-10-21T18:48:51.000Z
git-svn-id: file:///svn/phpbb/trunk@8214 89ea8834-ac86-4346-8a33-228a782c2dd0
diff --git a/phpBB/docs/CHANGELOG.html b/phpBB/docs/CHANGELOG.html
@@ -94,6 +94,7 @@ <h1>Changelog</h1>
 		<li>[Fix] Quote bbcode fixes. Letting parse quote=&quot;[&quot; and re-allowing whitelisted bbcodes within username portion (Bug #14770)</li>
 		<li>[Sec] Fix bbcode helpline display for custom bbcodes - this requires style changes for any custom style (Bug #14850)</li>
 		<li>[Fix] Correctly count announcements when filtering forums by date (Bug #14877)</li>
+		<li>[Fix] Allow charset names containing underscores or spaces</li>
 	</ul>
 
 	<a name="v30rc6"></a><h3>1.ii. Changes since 3.0.RC6</h3>
diff --git a/phpBB/includes/utf/utf_tools.php b/phpBB/includes/utf/utf_tools.php
@@ -768,7 +768,7 @@ function utf8_recode($string, $encoding)
 	}
 
 	// If nothing works, check if we have a custom transcoder available
-	if (!preg_match('#^[a-z0-9\\-]+$#', $encoding))
+	if (!preg_match('#^[a-z0-9_ \\-]+$#', $encoding))
 	{
 		// Make sure the encoding name is alphanumeric, we don't want it to be abused into loading arbitrary files
 		trigger_error('Unknown encoding: ' . $encoding, E_USER_ERROR);

Original file line number	Diff line number	Diff line change
`@@ -768,7 +768,7 @@ function utf8_recode($string, $encoding)`
`768`	`768`	`}`
`769`	`769`
`770`	`770`	`// If nothing works, check if we have a custom transcoder available`
`771`		`- if (!preg_match('#^[a-z0-9\\-]+$#', $encoding))`
	`771`	`+ if (!preg_match('#^[a-z0-9_ \\-]+$#', $encoding))`
`772`	`772`	`{`
`773`	`773`	`// Make sure the encoding name is alphanumeric, we don't want it to be abused into loading arbitrary files`
`774`	`774`	`trigger_error('Unknown encoding: ' . $encoding, E_USER_ERROR);`