Skip to content

Commit f034aee

Browse files
committed
Remove unused isCi var
1 parent 972806b commit f034aee

3 files changed

Lines changed: 2 additions & 7 deletions

File tree

packages/server/webpack.config.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ const HappyPack = require("happypack");
66

77
module.exports = merge({
88
devtool: "none",
9+
mode: "development",
910
module: {
1011
rules: [
1112
{
@@ -56,6 +57,4 @@ module.exports = merge({
5657
"process.env.CLI": `"${process.env.CLI ? "true" : "false"}"`,
5758
}),
5859
],
59-
}, require("../../scripts/webpack.general.config")(), {
60-
mode: "development",
61-
});
60+
}, require("../../scripts/webpack.general.config")());

packages/web/webpack.common.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ const vsFills = path.join(root, "packages/vscode/src/fill");
99
const merge = require("webpack-merge");
1010

1111
module.exports = merge({
12-
devtool: "source-map",
1312
entry: "./packages/web/src/index.ts",
1413
output: {
1514
chunkFilename: "[name]-[hash:6].bundle.js",

scripts/webpack.general.config.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
const path = require("path");
22
const environment = process.env.NODE_ENV || "development";
3-
const isCi = typeof process.env.CI !== "undefined";
43
const HappyPack = require("happypack");
54
const webpack = require("webpack");
65
const MiniCssExtractPlugin = require("mini-css-extract-plugin");
@@ -10,8 +9,6 @@ const root = path.join(__dirname, "..");
109
module.exports = (options = {}) => ({
1110
context: root,
1211
devtool: "source-map",
13-
// entry: "./packages/app/src/index.ts",
14-
mode: isCi ? "production" : "development",
1512
module: {
1613
rules: [{
1714
loader: "string-replace-loader",

0 commit comments

Comments
 (0)