Sometimes an exec has no callback

code-asher · kylecarbs · commit a0c443d8d3df · 2019-02-05T11:16:00.000-06:00
How lonely.
diff --git a/packages/protocol/src/browser/modules/child_process.ts b/packages/protocol/src/browser/modules/child_process.ts
@@ -32,12 +32,14 @@ export class CP {
 			if (typeof options === "function") {
 				callback = options;
 			}
-			// @ts-ignore not sure how to make this work.
-			callback(
-				error,
-				useBuffer(options) ? Buffer.from(stdout) : stdout,
-				useBuffer(options) ? Buffer.from(stderr) : stderr,
-			);
+			if (callback) {
+				// @ts-ignore not sure how to make this work.
+				callback(
+					error,
+					useBuffer(options) ? Buffer.from(stdout) : stdout,
+					useBuffer(options) ? Buffer.from(stderr) : stderr,
+				);
+			}
 		});
 
 		// @ts-ignore TODO: not fully implemented
