Cleanup, dns lookup fixed when error is thrown

BornToBeRoot · BornToBeRoot · commit 7afba16ca03e · 2019-10-17T20:42:35.000+02:00
diff --git a/Source/NETworkManager/Models/Network/DNSLookup.cs b/Source/NETworkManager/Models/Network/DNSLookup.cs
@@ -99,18 +99,25 @@ public void ResolveAsync(List<string> hosts)
                         dnsLookupClient.Timeout = Timeout;
                         dnsLookupClient.Retries = Retries;
 
-                        // PTR vs A, AAAA, CNAME etc.
-                        var dnsResponse = QueryType == QueryType.PTR ? dnsLookupClient.QueryReverse(IPAddress.Parse(host)) : dnsLookupClient.Query(host, QueryType, QueryClass);
-
-                        // If there was an error... return
-                        if (dnsResponse.HasError)
+                        try
                         {
-                            OnLookupError(new DNSLookupErrorArgs(dnsResponse.ErrorMessage, dnsResponse.NameServer.Endpoint));
-                            return;
+                            // PTR vs A, AAAA, CNAME etc.
+                            var dnsResponse = QueryType == QueryType.PTR ? dnsLookupClient.QueryReverse(IPAddress.Parse(host)) : dnsLookupClient.Query(host, QueryType, QueryClass);
+
+                            // If there was an error... return
+                            if (dnsResponse.HasError)
+                            {
+                                OnLookupError(new DNSLookupErrorArgs(dnsResponse.ErrorMessage, dnsResponse.NameServer.Endpoint));
+                                return;
+                            }
+
+                            // Process the results...
+                            ProcessDnsQueryResponse(dnsResponse);
+                        }
+                        catch(Exception ex)
+                        {
+                            OnLookupError(new DNSLookupErrorArgs(ex.Message, dnsServer));
                         }
-
-                        // Process the results...
-                        ProcessDnsQueryResponse(dnsResponse);
                     });
                 }
 
diff --git a/Source/NETworkManager/app.manifest b/Source/NETworkManager/app.manifest
@@ -12,15 +12,6 @@
 
   <compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
     <application>
-      <!-- Windows 7 - Dropped support with version 2.0 -->
-      <!-- <supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}" /> -->
-
-      <!-- Windows 8 - Dropped support with version 2.0 -->
-      <!-- <supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}" /> -->
-
-      <!-- Windows 8.1 - Dropped support with version 2.0 -->
-      <!-- <supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}" /> -->
-
       <!-- Windows 10 -->
       <supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}" />
     </application>
