Skip to content

Clear errors when routers fail DHCP and need to be bounced - #21

Open
db3922 wants to merge 16 commits into
mainfrom
att/4.22.0.0
Open

db3922 wants to merge 16 commits into
mainfrom
att/4.22.0.0

Conversation

@db3922

@db3922 db3922 commented Sep 14, 2026

Copy link
Copy Markdown

Description

Clear errors when routers fail DHCP and need to be bounced

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

harikrishna-patnala and others added 16 commits October 30, 2025 19:23
Signed-off-by: Harikrishna Patnala <harikrishna.patnala@gmail.com>
* initial updates for fiberchannel livemigrate

* fix storagemotion test case issue

* fix VMSnapshotStrategyKVMTest

* fix checkstyle and compile error

---------

Co-authored-by: Glover, Rene (rg9975) <rg9975@att.com>
* Trigger target workflow

* Added ability to trigger target workflow via API or workflow run

* Updated workflow run reference (branch) that target workflow resides
Check the searchFilters type before using the sub functions, ex: forEach
… Add Network Page (#8)

Load all projects user authorized to see in projects dropdown list on Add Network Page. Also enable the page size and search feature to search the list behind the default load
Fix unhandled error when the response from API listNetworkOfferings is empty and causing TypeError on JS code.

This is to prevent a crash and showing pop up error window — If the API returns a response where listnetworkofferingsresponse has no networkoffering key (which happens when there are zero results — CloudStack omits empty arrays in JSON responses), the value would be undefined. The next line calls .filter() on it, which would throw TypeError: Cannot read properties of undefined (reading 'filter').
Fixing missing label name for ACL name on Guest Networks page
Reliable ID generation from FQDN instead of NIC MAC.
* API Server for unhandled exception.
* User data.
* Snapshot clean up.
* Host storage access groups.
* Action options not showing up on Accounts page for large projects which exceeds the default resultset size on the server side, ex: with 200+ users

* Removing trailing whitespace

Removing trailing whitespace
This reverts commit d23f174.

FiberChannel volume migration from this PR was non-functional and never
thoroughly tested:

- Offline (stopped VM): the agent LibvirtMigrateVolumeCommandWrapper selected
  the live block-copy path whenever the volume carried a vmName, ignoring VM
  power state. A stopped VM has no libvirt domain, so domainLookupByName threw
  "no domain with matching name 'i-<acct>-<id>-VM'" and the migration failed
  with StorageUnavailableException.
- Online (running VM): never worked.

Reverting restores the known-good behavior where FiberChannel volume migrations
use the offline migrateRegularVolume path.
Revert "4.22 FC VOL LIVEMIGRATE (#1)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants