Adds a safeguard to prevent duplicate VM scheduled jobs and prevent continuously printing errors in logs - #19
Open
manikonda wants to merge 1 commit into
Conversation
…y checking for existing jobs before creating new ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a safeguard to prevent duplicate VM scheduled jobs and prevent continuously printing errors in logs.
This pull request adds a safeguard to prevent duplicate VM scheduled jobs by checking for existing jobs before creating new ones. It introduces a new DAO method to efficiently find jobs by schedule and timestamp, and updates the scheduler logic to use this method. Additionally, it introduces some minor import changes.
Database access improvements:
Added a new method findByScheduleAndTimestamp(long scheduleId, Date scheduledTimestamp) to the VMScheduledJobDao interface and its implementation, along with the necessary SearchBuilder in VMScheduledJobDaoImpl, to efficiently look up scheduled jobs by schedule ID and timestamp.
Scheduler logic enhancements:
Updated VMSchedulerImpl.scheduleNextJob to use the new DAO method to check for an existing scheduled job before creating a new one, preventing duplicate scheduling for the same VM and time.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
How Has This Been Tested?
Created schedules on the VM using the cloudstack UI and validated from the logs, to see if this change stopped printing the SQL ERROR statements continuously on each new poll check intervals, usually 1 minute.