Conversation
…r session Fixing black page showing up sometimes when login with the new browser session. This ensures Vue Router re-resolves /dashboard against the route table after the dynamic routes have been added via router.addRoute(), rather than reusing the stale to object that was resolved when /dashboard didn't exist yet (causing the blank page on first login).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes black page showing up sometimes when login with the new browser session. This ensures Vue Router re-resolves /dashboard against the route table after the dynamic routes have been added via router.addRoute(), rather than reusing the stale to object that was resolved when /dashboard didn't exist yet (causing the blank page on first login).
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
How Has This Been Tested?
Login into the Cloudstack UI with the new browser (clean cache before opening) and try to login to the main landing page. After the login (SSO or MFA) it should display the default home/route page, which is dashboard. Before this change, sometime it just shows empty page due to race conditions of the dataset loads and APIs executions in parallel