Skip to content

Revert "4.22 FC VOL LIVEMIGRATE (#1)" - #17

Merged
mp940m merged 1 commit into
att:att/4.22.0.0from
poddm:mp/FLXCLD-2900
Aug 25, 2026
Merged

mp940m merged 1 commit into
att:att/4.22.0.0from
poddm:mp/FLXCLD-2900

Conversation

@poddm

@poddm poddm commented Aug 24, 2026

Copy link
Copy Markdown

This reverts commit d23f174.

FiberChannel volume migration from this PR was non-functional and never thoroughly tested:

  • Offline (stopped VM): the agent LibvirtMigrateVolumeCommandWrapper selected the live block-copy path whenever the volume carried a vmName, ignoring VM power state. A stopped VM has no libvirt domain, so domainLookupByName threw "no domain with matching name 'i---VM'" and the migration failed with StorageUnavailableException.
  • Online (running VM): never worked.

Reverting restores the known-good behavior where FiberChannel volume migrations use the offline migrateRegularVolume path.

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

This reverts commit d23f174.

FiberChannel volume migration from this PR was non-functional and never
thoroughly tested:

- Offline (stopped VM): the agent LibvirtMigrateVolumeCommandWrapper selected
  the live block-copy path whenever the volume carried a vmName, ignoring VM
  power state. A stopped VM has no libvirt domain, so domainLookupByName threw
  "no domain with matching name 'i-<acct>-<id>-VM'" and the migration failed
  with StorageUnavailableException.
- Online (running VM): never worked.

Reverting restores the known-good behavior where FiberChannel volume migrations
use the offline migrateRegularVolume path.

@db3922 db3922 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@mp940m
mp940m merged commit fab8879 into att:att/4.22.0.0 Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants