Skip to content

Display "thinking..." state while fetching network time in Christmas app #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
atarukun merged 4 commits into from
Oct 30, 2025
Merged

Display "thinking..." state while fetching network time in Christmas app #9

atarukun merged 4 commits into from
Oct 30, 2025

Conversation

Copy link

Copilot AI commented Oct 30, 2025 •
edited
Loading

  • Understand the current code and network fetch mechanism
  • Remove fallback to local time (per requirement: "should not ever use the local version of the date")
  • Add "thinking..." state while fetching network date
  • Implement retry logic with visual feedback (5 second retry interval)
  • Add periodic refresh attempts when network fetch fails
  • Verify the implementation works as expected (tests pass)
  • Address code review comments
  • Final security check with CodeQL (no alerts)
  • Fix duplicate "thinking..." display issue

Summary

Successfully implemented the "thinking" state for the Christmas countdown app with all review feedback addressed.

Latest Fix

  • Prevented "thinking..." from being displayed twice (both in center and at bottom)
  • Now only shows "thinking..." in the center while waiting for network
  • Date at bottom only appears once real date is fetched
Original prompt

The new date listed on the bottom now shows the problem more clearly. The date is being shown as 01 Jan 2021. That makes me think the network call to get today's actual date is failing.

Please change the christmas application so that it displays, "thinking" while it tries to get today's date to determine how many days it will be until christmas. And it should refresh regularly as it tries to connect over the network, finally updating to show the days until Christmas after successfully retrieving the date from the network.

It should not ever use the local version of the date.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits October 30, 2025 16:57
@atarukun
Implement thinking state and network retry logic for Christmas app
b75794d 
Co-authored-by: atarukun <6511495+atarukun@users.noreply.github.com>
@atarukun
Fix code review comments: clarify return value and update comment
daf4c75 
Co-authored-by: atarukun <6511495+atarukun@users.noreply.github.com>
Copilot AI changed the title [WIP] Update christmas application to show loading state for date retrieval Display "thinking..." state while fetching network time in Christmas app Oct 30, 2025
Copilot AI requested a review from atarukun October 30, 2025 17:04
@atarukun atarukun marked this pull request as ready for review October 30, 2025 17:08
Copilot AI review requested due to automatic review settings October 30, 2025 17:08
Copilot AI reviewed Oct 30, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a retry mechanism with exponential backoff for network date fetching and improves UX by showing a "thinking..." message instead of falling back to local time. The key changes ensure that failed API requests are retried more frequently (every 5 seconds) until successful, after which the fetch interval returns to once per hour.

  • Adds a _fetch_success flag to track API fetch status and separate retry/success intervals
  • Removes local time fallback, displaying "thinking..." when date is unavailable
  • Updates retry logic to use shorter intervals after failures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@atarukun
Fix: prevent displaying 'thinking...' twice on screen
6ea1703 
Co-authored-by: atarukun <6511495+atarukun@users.noreply.github.com>
atarukun
atarukun approved these changes Oct 30, 2025
View reviewed changes
Copy link
Owner

@atarukun atarukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atarukun atarukun merged commit 668b530 into christmas Oct 30, 2025
@atarukun atarukun deleted the copilot/update-christmas-app-date-display branch October 30, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@atarukun atarukun atarukun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@atarukun atarukun

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@atarukun