Skip to content

Filter out astropy core package from pyOpenSci Affiliated listing #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hamogu merged 1 commit into from
Jan 21, 2026
Merged

Filter out astropy core package from pyOpenSci Affiliated listing #699

hamogu merged 1 commit into from
Jan 21, 2026

Conversation

@pllim
Copy link
Member

@pllim pllim commented Jan 20, 2026 •
edited
Loading

@pllim pllim marked this pull request as ready for review January 20, 2026 18:54
@pllim pllim requested review from dhomeier and hamogu January 20, 2026 18:54
@pllim pllim mentioned this pull request Jan 20, 2026
Open
10 tasks
hamogu
hamogu requested changes Jan 21, 2026
View reviewed changes
Copy link
Member

@hamogu hamogu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see it listed. Is the name "astropy" or did PyOpenSci names it "astropy core package" (which doesn't trigger the continue statement)?

Screenshot 2026-01-21 at 8 13 06 AM

@hamogu
Copy link
Member

hamogu commented Jan 21, 2026

I also think the "maintainers" entry is not right but since our goal is not display the core package at all in this list, we don't have to worry about that at this point.
(And @pllim already pointed out in pyOpenSci/software-submission#251 that the author/maintainer field is messed up upstream).

@pllim
Copy link
Member Author

pllim commented Jan 21, 2026

@hamogu , I don't think my code touches Coordinated Packages listing at https://www.astropy.org/affiliated/index.html#coordinated-package-list

I think changing this one is out of scope here and should be done in a separate PR?

astropy.github.com/affiliated/registry.json

Line 120 in ed29abb

"maintainer": "Astropy Coordination Committee",

@hamogu hamogu merged commit 6fa4a54 into astropy:main Jan 21, 2026
2 checks passed
@pllim pllim deleted the fix-affil-filter branch January 21, 2026 16:26
@pllim
Copy link
Member Author

pllim commented Jan 21, 2026

Thanks for the merge, @hamogu . Do you want me to open follow-up PR for Coordinated listing you pointed out at #699 (review) ?

@hamogu hamogu mentioned this pull request Jan 21, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hamogu hamogu hamogu requested changes

@dhomeier dhomeier Awaiting requested review from dhomeier

Assignees

No one assigned

Labels

affiliated-packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Affiliated listing JS code to filter out astropy core package

2 participants

@pllim @hamogu