DEP: drop support for Python 3.11, require 3.12+ - #20223
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
46db999 to
fa7a591
Compare
|
(from cycler via matplotlib) edit: resolved by constraining |
2582b4c to
b504b8f
Compare
|
Still hitting this error, and still getting six==1.9.0 despite the constraint. I'm suspecting a cache invalidation issue with tox, tox-uv, or OpenAstronomy/github-actions-workflows, but nothing conclusive yet. |
|
The cached This looks like something is broken in |
9b772ee to
ee22592
Compare
|
Nevermind, my constraint just contained a typo. The fix was diff --git a/pyproject.toml b/pyproject.toml
index 7436fe9f2d..c3bfa6efb6 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -829,7 +829,7 @@ required-environments = [
constraint-dependencies = [
"asdf>=2.15.1",
"asdf-coordinates-schemas>=0.2.0",
- "six>=0.16.0", # for Python 3.12+ compat
+ "six>=1.16.0", # for Python 3.12+ compat
# via pytest
# iniconfig 1.0.1 is the first version with proper wheels |
ee22592 to
3cb8083
Compare
99d2d24 to
44e4a9d
Compare
mhvk
left a comment
There was a problem hiding this comment.
Thanks so much! I had been considering doing it myself and now realize how much I would've missed... Two comments, neither of which is essential.
| } | ||
|
|
||
| Py_INCREF(Py_None); | ||
| return Py_None; |
There was a problem hiding this comment.
Could replace (here and below) with Py_RETURN_NONE - which I like in that the reference counting is just hidden (i.e., one does not have to know Py_None is immortal).
There was a problem hiding this comment.
good call. I'll push out a separate commit just in case and will squash it if everything stays green.
|
|
||
| - name: Python 3.11 with oldest supported version of all dependencies | ||
| linux: py311-test-oldestdeps-alldeps-cov-clocale | ||
| - name: Python 3.12 with oldest supported version of all dependencies |
There was a problem hiding this comment.
Would it make sense to bump all the python versions by 1? Perhaps best to do that when a new python release is made, but then it has to be clear which jobs need the minimum python version. Perhaps mark these? (here it is fairly obvious, but maybe below not).
There was a problem hiding this comment.
We typically can't upgrade every job as soon as a new Python comes around without hitting some dependencies missing wheels for it, so I don't think we should wait for 3.15's release if we're going to do that. We could upgrade 3.13 jobs to 3.14 now, but it seems slightly orthogonal to this PR. Maybe @pllim would argue that we might just as well change all required env names in a single sweeping PR though. Until she weighs in, I'll just make sure that every job that needs the oldest supported version has a comment to explain it.
89e41ff to
afab778
Compare
|
This is stable now and ready for formal reviews. |
afab778 to
43e9d23
Compare
mhvk
left a comment
There was a problem hiding this comment.
Thanks for chasing all those loose ends down! Looks all OK to me.
|
whoops, I'm only just now seeing an error on double-tests jobs, which I don't immediately get off-hand. Re-drafting for now. Hopefully I'll figure it out tomorrow. |
|
Thanks. No reason to keep this drafted then ! |
142d66a to
dab8f97
Compare
dab8f97 to
0339b70
Compare
Description
As discussed in
close #18229
close #20184 (I think ?)