TST: upgrade Stable CI jobs to CPython 3.13#19436
Draft
neutrinoceros wants to merge 1 commit intoastropy:mainfrom
Draft
TST: upgrade Stable CI jobs to CPython 3.13#19436neutrinoceros wants to merge 1 commit intoastropy:mainfrom
neutrinoceros wants to merge 1 commit intoastropy:mainfrom
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Member
|
Yeah... but as you can see in the CI listing, it messes up with everyone else because we have to update the branch protection rules and ask everyone to rebase. Unless not upgrading is going to break something, I'd rather wait for when we bump Python or at least during a quiet time when we don't get so many PRs from GSoC hopefuls. |
Contributor
Author
|
Good point, I didn't consider the context. It felt like a good time to me because I disabled most notifications from misc activity, but this can definitely wait for GSoC season to die off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This seems overdue. Last time I checked, we did this once a year and at the same time as we bumped our minimal requirement on Python itself, but I think this approach isn't appropriate now that astropy is abi3-compliant and there's much less of a motivation for aggressively bumping the requirement. Meanwhile, CPython 3.13 has been stable for almost 18 months now, so I think it's very safe to use it as our primary version in CI.