Skip to content

TST: upgrade Allowed Failures job to CPython 3.14#19435

Draft
neutrinoceros wants to merge 1 commit intoastropy:mainfrom
neutrinoceros:tst/cp314-allowed-failures
Draft

TST: upgrade Allowed Failures job to CPython 3.14#19435
neutrinoceros wants to merge 1 commit intoastropy:mainfrom
neutrinoceros:tst/cp314-allowed-failures

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

Description

I don't know of any blockers against this.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v8.0.0 milestone Mar 16, 2026
@neutrinoceros neutrinoceros added testing no-changelog-entry-needed dependencies Pull requests that update a dependency file labels Mar 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

of course this would look a lot better if the one affected job could be green, just this one time. I don't think the error is related but I'll try to re-run and see if it's just a network flake first.

@pllim pllim force-pushed the tst/cp314-allowed-failures branch from 0b4673e to c4eaa0b Compare March 16, 2026 16:17
@pllim

This comment was marked as outdated.

@pllim
Copy link
Copy Markdown
Member

pllim commented Mar 16, 2026

I think the failures are related. I vaguely remember some file pointer thingy changed in Python 3.14 but I don't remember where we discussed it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants